gh-153534: Broaden _asyncio _call_soon fast path to safe BaseEventLoop subclasses#153535
Draft
KRRT7 wants to merge 1 commit into
Draft
gh-153534: Broaden _asyncio _call_soon fast path to safe BaseEventLoop subclasses#153535KRRT7 wants to merge 1 commit into
_asyncio _call_soon fast path to safe BaseEventLoop subclasses#153535KRRT7 wants to merge 1 commit into
Conversation
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
_asyncio _call_soon fast path to safe BaseEventLoop subclasses_asyncio _call_soon fast path to safe BaseEventLoop subclasses
3360616 to
2bb306d
Compare
f06be0e to
b2c13fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes gh-153534.
This broadens
_asyncio's internalcall_soon()helper to use the private_call_soon()fast path for safe subclasses of stdlibasyncio.base_events.BaseEventLoop, not just exact built-in loop types.The fast path now applies only when the loop:
BaseEventLoopsubclasscall_soonon the subclass typecall_soonon the instanceOtherwise
_asynciofalls back to the publiccall_soon()path.This preserves behavior for custom loop behavior while expanding the
optimization to the common subclass-without-override case.
Notes
BaseEventLoopduring_asyncioinit because_asynciois imported whileasyncio.base_eventsis still initializingand that creates an import cycle